On Saturday 27 March 2021 15:42:13 Marek Behún wrote: > On Sat, 27 Mar 2021 14:29:59 +0100 > Pali Rohár <pali@xxxxxxxxxx> wrote: > > > I can change this to 'if (!ret)' if needed, no problem. > > > > I use 'if (!val)' mostly for boolean and pointer variables. If > > variable can contain more integer values then I lot of times I use > > '=='. > > Comparing integer varibales with explicit literals is sensible, but > if a function returning integer returns 0 on success and negative value > on error, Linux kernel has a tradition of using just > if (!ret) > or > if (ret) > > Marek Ok, I will change it.