Hi Colin, > The pointer dev is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed. [...] > - struct device *dev = epf->epc->dev.parent; > + struct device *dev; > struct pci_epf_bar *epf_bar; > struct pci_epc *epc; Thank you! Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx> Krzysztof