On Sun, Feb 21, 2021 at 08:29:02PM +0100, Krzysztof Wilczyński wrote: > [+cc Lorenzo for visiblity] > > Hi, > > Thank you for taking care of this! > > [...] > > PCI_FUNC(port->slot << 3)" is always 0, so previously > > mtk_pcie_startup_port() only configured FC credits and FTs for > > function 0. > [...] > > A small nit. The commit message is missing the opening quote, see > Bjorn's suggestion: > > https://lore.kernel.org/linux-pci/20201104131054.GA307984@bjorn-Precision-5520/ > > But, it's probably not worth sending another patch, and perhaps either > Bjorn or Lorenzo could fix this when applying changes. > > Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx> Thanks, I will do. Can I apply it or there are still pending review comments to address ? Lorenzo