Hi Yicong,
> We use format domain:bus:slot.function when print
> PCI device. Use consistent format in AER messages.
A small nitpick: the commit message and in the subject line it should
probably use "printing" rather than "print". But I suppose whoever is
going be applying this patch can fix this, so probably no need to send
another version, unless you really want to do it.
[...]
> - pr_err("AER recover: Can not find pci_dev for %04x:%02x:%02x:%x\n",
> + pr_err("AER recover: Can not find pci_dev for %04x:%02x:%02x.%x\n",
> entry.domain, entry.bus,
> PCI_SLOT(entry.devfn), PCI_FUNC(entry.devfn));
[...]
> - pr_err("AER recover: Buffer overflow when recovering AER for %04x:%02x:%02x:%x\n",
> + pr_err("AER recover: Buffer overflow when recovering AER for %04x:%02x:%02x.%x\n",
> domain, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
Seems like a good idea! This BDF-like notation is used at few other
places. Nice catch.
Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx>
Krzysztof
