On Mon, 2011-04-04 at 09:25 -0600, Bjorn Helgaas wrote: > Some of this is reminiscent of the ACPI/PCI binding we do on x86/ia64, > e.g., acpi_get_pci_dev() and the stuff in drivers/acpi/glue.c. Have > you looked at that to see if there's any hope of covering both OF and > ACPI with something more generic? Hrm, the ACPI stuff is quite different (to some extent akin to what power used to do) form what I can tell. You basically traverse the ACPI tree do perform a matching after the fact. The idea with my patch is really to populate things as they get discovered, which makes the code much simpler. Since we have the pointer to the OF device node in the generic struct device nowadays, if we populate things that way, by the time we discover a device we already have at hand the OF device node of the parent bus, so it's a single/simpler one level search to locate the device itself and populate it's node as well, done once for all. I suppose you could do something similar for ACPI, but I wouldn't try to make a "common infrastructure" at that point, especially since there is the possibility on x86 to have both OF device-trees and ACPI :-) Note that I don't really provide a direct/good equivalent of your acpi_get_pci_dev() ... the matching is mostly used the other way around, ie a driver for a pci_dev wanting to peek a some properties in the corresponding OF device_node. ppc32 has some reverse mapping stuff but it's pretty crappy (and on my to-fixup list for after that patch goes in) and in fact it would be reasonably easy from now on to implement it as well, but so far there is no real demand. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
