On Mon, 08 Mar 2021, Andy Shevchenko wrote: > Factor out duplicate code to lpc_ich_enable_spi_write() helper function. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/mfd/lpc_ich.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) You are adding way more lines than you're saving here. It's not a horrible change, so: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog