On 7.3.2021 2.22, Krzysztof Wilczyński wrote: > Hi Antti, > > A few nitpicks, so feel free to ignore these, of course. > > If possible, capitalise the subject line. Also, perhaps "Add quirk to > prevent bus (...)" might read better. > >> Some TI keystone C667X devices do no support bus/hot reset. Its PCIESS > [...] > > It would be KeyStone in the above sentence. > > [...] >> With this change device can be assigned to VMs with VFIO, but it will >> leak state between VMs. > > Following-up on Bojrn's question about the state leak, see: > https://lore.kernel.org/linux-pci/20210129234946.GA124037@bjorn-Precision-5520/ > > Would there be anything else that has to be done? > To my understanding this is all that needs to be done. At least on other similar case, adding quirk was the only change https://lore.kernel.org/patchwork/patch/1086083/