On Thu, Mar 4, 2021 at 12:03 PM Keith Busch <kbusch@xxxxxxxxxx> wrote: > > On Tue, Mar 02, 2021 at 09:46:40PM -0800, Kuppuswamy, Sathyanarayanan wrote: > > > > On 3/2/21 9:34 PM, Williams, Dan J wrote: > > > [ Add Sathya ] > > > > > > On Mon, 2021-01-04 at 15:02 -0800, Keith Busch wrote: > > > > Overwriting the frozen detected status with the result of the link reset > > > > loses the NEED_RESET result that drivers are depending on for error > > > > handling to report the .slot_reset() callback. Retain this status so > > > > that subsequent error handling has the correct flow. > > > > > > > > Reported-by: Hinko Kocevar <hinko.kocevar@xxxxxx> > > > > Acked-by: Sean V Kelley <sean.v.kelley@xxxxxxxxx> > > > > Signed-off-by: Keith Busch <kbusch@xxxxxxxxxx> > > > Just want to report that this fix might be a candidate for -stable. > > Agree. > > > > I think it can be merged in both stable and mainline kernels. > > > > Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> > > Just FYI, this patch is practically a revert of this one: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=6d2c89441571ea534d6240f7724f518936c44f8d > > so please let me know if that is still a problem for you. For what it's worth I think "6d2c89441571 PCI/ERR: Update error status after reset_link()" is not justified. The link shouldn't recover if the attached device is not prepared to handle DPC events. As far as I can see it's just a cosmetic fix, right? Sathya, was there some end user visible need to make the DPC recovery report "success" in this case?
