Hi Krzysztof,
Thanks for your review,
On Wed, 2021-02-24 at 15:10 +0100, Krzysztof Wilczyński wrote:
> Hi Jianjun,
>
> > Add suspend_noirq and resume_noirq callback functions to implement
> > PM system suspend hooks for MediaTek Gen3 PCIe controller.
>
> So, "systems suspend" and "resume" hooks, correct?
The callback functions is suspend_noirq and resume_noirq, should I use
"systems suspend" and "resume" in the commit message?
>
> > When system suspend, trigger the PCIe link to L2 state and pull down
>
> It probably would be "the system suspends".
>
> [...]
> > When system resum, the PCIe link should be re-established and the
> > related control register values should be restored.
>
> Similarly to the above: "the system resumes".
>
> [...]
> > + if (err) {
> > + dev_err(port->dev, "can not enter L2 state\n");
> > + return err;
> > + }
>
> Most likely you want "cannot" or "can't" in the above error message.
>
> > + /* Pull down the PERST# pin */
> > + val = readl_relaxed(port->base + PCIE_RST_CTRL_REG);
> > + val |= PCIE_PE_RSTB;
> > + writel_relaxed(val, port->base + PCIE_RST_CTRL_REG);
> > +
> > + dev_dbg(port->dev, "enter L2 state success");
>
> Just a nitpick. What about "entered L2 states successfully"?
>
> [...]
> > + if (err) {
> > + dev_err(port->dev, "resume failed\n");
> > + return err;
> > + }
>
> This error message does not quite convey that the mtk_pcie_startup_port()
> was the function that failed, which is only a part of what you have to do
> to successfully resume.
>
> > + dev_dbg(port->dev, "resume done\n");
>
> A nitpick. Probably not needed, as lack of error message would mean
> that the device resumed successfully after being suspended.
>
> Krzysztof
Thanks.
