> ... > > I took your suggestion and came up with the following: > > Function rcec_assoc_rciep() incorrectly used "rciep->devfn" (a single > byte encoding the device and function number) as the device number to > check whether the corresponding bit was set in the RCiEPBitmap of the > RCEC (Root Complex Event Collector) while enumerating over each bit of > the RCiEPBitmap. > > As per the PCI Express Base Specification, Revision 5.0, Version 1.0, > Section 7.9.10.2, "Association Bitmap for RCiEPs", p. 935, only needs to > use a device number to check whether the corresponding bit was set in > the RCiEPBitmap. > > Fix rcec_assoc_rciep() using the PCI_SLOT() macro and convert the value > of "rciep->devfn" to a device number to ensure that the RCiEP devices > are associated with the RCEC are linked when the RCEC is enumerated. > > Using either of the following as the subject: > > PCI/RCEC: Use device number to check RCiEPBitmap of RCEC > PCI/RCEC: Fix RCiEP capable devices RCEC association > > What do you think? Also, feel free to change whatever you see fit, of course, as > tis is only a suggestion. > Hi Krzysztof, Thanks for improving the commit message. It looks clearer. 😊 Will send out a v2 with this commit message. Thanks! -Qiuxu
