On 17.02.21 00:02:45, Dejin Zheng wrote: > Introduce pcim_alloc_irq_vectors(), a device-managed version of > pci_alloc_irq_vectors(), In some i2c drivers, If pcim_enable_device() > has been called before, then pci_alloc_irq_vectors() is actually a > device-managed function. It is used as a device-managed function, So > replace it with pcim_alloc_irq_vectors(). > > Changelog > --------- > v2 -> v3: > - Add some commit comments for replace some codes in > pcim_release() by pci_free_irq_vectors(). > - Simplify the error handling path in i2c designware > driver. > v1 -> v2: > - Use pci_free_irq_vectors() to replace some code in > pcim_release(). > - Modify some commit messages. > > Dejin Zheng (4): > PCI: Introduce pcim_alloc_irq_vectors() > Documentation: devres: Add pcim_alloc_irq_vectors() This is already taken care of, see pcim_release(): if (dev->msi_enabled) pci_disable_msi(dev); if (dev->msix_enabled) pci_disable_msix(dev); Activated when used with pcim_enable_device(). This series is not required. -Robert > i2c: designware: Use the correct name of device-managed function > i2c: thunderx: Use the correct name of device-managed function > > .../driver-api/driver-model/devres.rst | 1 + > drivers/i2c/busses/i2c-designware-pcidrv.c | 15 +++------ > drivers/i2c/busses/i2c-thunderx-pcidrv.c | 2 +- > drivers/pci/pci.c | 33 ++++++++++++++++--- > include/linux/pci.h | 3 ++ > 5 files changed, 38 insertions(+), 16 deletions(-) > > -- > 2.25.0 >