RE: [PATCH v7 1/2] dt-bindings: PCI: Add Intel Keem Bay PCIe controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

Thank you for the review.

> -----Original Message-----
> From: Krzysztof Wilczyński <kw@xxxxxxxxx>
> Sent: Wednesday, February 10, 2021 6:12 AM
> To: Thokala, Srikanth <srikanth.thokala@xxxxxxxxx>
> Cc: bhelgaas@xxxxxxxxxx; robh+dt@xxxxxxxxxx; lorenzo.pieralisi@xxxxxxx;
> linux-pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> andriy.shevchenko@xxxxxxxxxxxxxxx; mgross@xxxxxxxxxxxxxxx; Raja
> Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@xxxxxxxxx>;
> Sangannavar, Mallikarjunappa <mallikarjunappa.sangannavar@xxxxxxxxx>
> Subject: Re: [PATCH v7 1/2] dt-bindings: PCI: Add Intel Keem Bay PCIe
> controller
> 
> Hi Srikanth,
> 
> Thank you for working on this new driver!
> 
> [...]
> > +title: Intel Keem Bay PCIe controller endpoint mode
> [...]
> > +title: Intel Keem Bay PCIe controller root complex mode
> [...]
> 
> Not sure if worth spending on this, but I've noticed that people often
> capitalise "Root Complex" and "Endpoint" when talking about PCIe
> controller
> features - you did the same in the cover letter, so I wonder if you want
> to keep this consistent.

Sure I will make change to keep it consistent.

Thanks!
Srikanth


> 
> Krzysztof




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux