On 4 March 2011 21:43, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2 Mar 2011 22:34:17 +0530 > <Narendra_K@xxxxxxxx> wrote: > >> On Wed, Feb 23, 2011 at 06:06:42PM +0530, K, Narendra wrote: >> > Hello, >> > >> > This patch exports ACPI _DSM provided firmware instance number and >> > string name to sysfs. >> > >> > V1 -> V2: >> > The attribute 'index' is changed to 'acpi_index' as the semantics of >> > SMBIOS provided device type instance and ACPI _DSM provided firmware >> > instance number are different. >> > >> > V2 -> V3: >> > Matthew Garrett pointed out that 'sysfs_create_groups' does return an >> > error when there are no ACPI _DSM attributes available and because of >> > that the fallback to SMBIOS will not happen. As a result SMBIOS provided >> > attributes are not created. This version of the patch addresses the issue. >> > >> >> V3 -> V4: >> Select NLS if (DMI || ACPI) in drivers/pci/Kconfig to prevent build >> breakage from an 'allmodconfig' > > Applied, fingers crossed this time. :) > Hi, It cannot be compiled if CONFIG_ACPI is not set. drivers/pci/pci-label.c: In function 'pci_create_firmware_label_files': drivers/pci/pci-label.c:366:2: error: implicit declaration of function 'device_has_dsm' -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html