Re: [PATCHv2 0/5] aer handling fixups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 09, 2021 at 05:06:14PM -0600, Bjorn Helgaas wrote:
> [+cc Hinko]
> 
> On Mon, Jan 04, 2021 at 03:02:55PM -0800, Keith Busch wrote:
> > Changes from v1:
> > 
> >   Added received Acks
> > 
> >   Split the kernel print identifying the port type being reset.
> > 
> >   Added a patch for the portdrv to ensure the slot_reset happens without
> >   relying on a downstream device driver..
> > 
> > Keith Busch (5):
> >   PCI/ERR: Clear status of the reporting device
> >   PCI/AER: Actually get the root port
> >   PCI/ERR: Retain status from error notification
> >   PCI/AER: Specify the type of port that was reset
> >   PCI/portdrv: Report reset for frozen channel
> > 
> >  drivers/pci/pcie/aer.c         |  5 +++--
> >  drivers/pci/pcie/err.c         | 16 +++++++---------
> >  drivers/pci/pcie/portdrv_pci.c |  3 ++-
> >  3 files changed, 12 insertions(+), 12 deletions(-)
> 
> I applied these to pci/error for v5.12, thanks!

Thanks!
 
> I *am* a little concerned about the issues Hinko saw because it
> doesn't look we found a root cause.  I didn't spend any time looking
> into it, but even if it only shows up on his specific platform or with
> some weird config combination, it's a problem.  But I guess we'll see
> if anybody else trips over it.

Yes, I'm also closely monitoring for AER issues. I think Hinko's
observation was seen without this series, and was just initially noticed
with it. I'm reasonably confident this is a safe improvement, but I want
to see this work well with everyone's hardware, too.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux