[+cc Fabio] Hi Bjorn, Lorenzo and Rob, [...] > > *** CID 1472841: Error handling issues (CHECKED_RETURN) > > /drivers/pci/controller/dwc/pci-exynos.c: 263 in exynos_pcie_host_init() > > 257 > > 258 pp->bridge->ops = &exynos_pci_ops; > > 259 > > 260 exynos_pcie_assert_core_reset(ep); > > 261 > > 262 phy_reset(ep->phy); > > >>> CID 1472841: Error handling issues (CHECKED_RETURN) > > >>> Calling "phy_power_on" without checking return value (as is done elsewhere 40 out of 50 times). > > 263 phy_power_on(ep->phy); > > 264 phy_init(ep->phy); > > 265 > > 266 exynos_pcie_deassert_core_reset(ep); > > 267 exynos_pcie_enable_irq_pulse(ep); > > 268 We also have the following defect detected in the same file, and it's of an identical nature - lack of error checking. The reported defect: 263 phy_power_on(ep->phy); CID 1471267 (#1 of 1): Unchecked return value (CHECKED_RETURN) 2. check_return: Calling phy_init without checking return value (as is done elsewhere 41 out of 49 times). 264 phy_init(ep->phy); This would also be quite trivial to fix, but I don't know much about Exons, thus I am not sure if there is anything special it would need aside of perhaps phy_power_off() and phy_exit(), etc. Krzysztof
