Re: [PATCH -v2] x86: early_quirk check all bus/dev/func in domain 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 07 Feb 2011 14:14:52 -0800
Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> 
> When we have 00:1a.0, 00:1a.1, 00:1a.2, 00:1a.7
> Found only 00:1a.0, and 00:1a.1 get processed. and 00:1a.2 and 00:1a.7 get skipped.
> 
> We should only check header type on func0.
> Also should not bail out when have gap.
> 
> At last try to process bus 00 - 0xff instead of only bus 00.
> 
> -v2: check with VENDOR_ID instead of CLASS_DEVICE for invalid device.
> 
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>

I need a much better changelog here.  It sounds (and looks) like the
patch is doing several things:
  - processing more than the first two functions on a device
  - processing the full set of busses in the first domain
  - checking for nonexistent devices

Why are you making these changes?  Do you have a system that needs
early quirks but violates the existing assumptions?  Can you apply a
standard quirk instead?

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux