Hi Rob / Thomas, Requesting to provide your reviews. Thanks & Regards, Nadeem Athani > -----Original Message----- > From: Kishon Vijay Abraham I <kishon@xxxxxx> > Sent: Tuesday, January 12, 2021 12:46 PM > To: Athani Nadeem Ladkhan <nadeem@xxxxxxxxxxx>; Tom Joseph > <tjoseph@xxxxxxxxxxx>; lorenzo.pieralisi@xxxxxxx; robh@xxxxxxxxxx; > bhelgaas@xxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; linux- > pci@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Cc: Milind Parab <mparab@xxxxxxxxxxx>; Swapnil Kashinath Jakhade > <sjakhade@xxxxxxxxxxx>; Parshuram Raju Thombare > <pthombar@xxxxxxxxxxx> > Subject: Re: [PATCH v7 0/2] PCI: cadence: Retrain Link to work around Gen2 > > EXTERNAL MAIL > > > > > On 30/12/20 5:35 pm, Nadeem Athani wrote: > > Cadence controller will not initiate autonomous speed change if > > strapped as Gen2. The Retrain Link bit is set as quirk to enable this speed > change. > > Adding a quirk flag for defective IP. In future IP revisions this will > > not be applicable. > > > > Version history: > > Changes in v7: > > - Changing the commit title of patch 1 in this series. > > - Added a return value for function cdns_pcie_retrain(). > > Changes in v6: > > - Move the position of function cdns_pcie_host_wait_for_link to remove > > compilation error. No changes in code. Separate patch for this. > > Changes in v5: > > - Remove the compatible string based setting of quirk flag. > > - Removed additional Link Up Check > > - Removed quirk from pcie-cadence-plat.c and added in pci-j721e.c > > Changes in v4: > > - Added a quirk flag based on a new compatible string. > > - Change of api for link up: cdns_pcie_host_wait_for_link(). > > Changes in v3: > > - To set retrain link bit,checking device capability & link status. > > - 32bit read in place of 8bit. > > - Minor correction in patch comment. > > - Change in variable & macro name. > > Changes in v2: > > - 16bit read in place of 8bit. > > Could get GEN2 card enumerated in GEN2 mode in J7ES EVM. > > Tested-by: Kishon Vijay Abraham I <kishon@xxxxxx> > > Thanks > Kishon > > > > Nadeem Athani (2): > > PCI: cadence: Shifting of a function to support new code. > > PCI: cadence: Retrain Link to work around Gen2 training defect. > > > > drivers/pci/controller/cadence/pci-j721e.c | 3 + > > drivers/pci/controller/cadence/pcie-cadence-host.c | 70 > ++++++++++++++++------ > > drivers/pci/controller/cadence/pcie-cadence.h | 11 +++- > > 3 files changed, 65 insertions(+), 19 deletions(-) > >
