On 2021-01-19 15:11, Johan Jonker wrote:
Hi Simon, Heiko,
On 1/19/21 2:14 PM, Heiko Stübner wrote:
Hi Johan,
Am Dienstag, 19. Januar 2021, 14:07:41 CET schrieb Johan Jonker:
Hi Simon,
Thank you for this patch for rk3568 pcie.
Include the Rockchip device tree maintainer and all other people/lists
to the CC list.
./scripts/checkpatch.pl --strict <patch1> <patch2>
./scripts/get_maintainer.pl --noroles --norolestats --nogit-fallback
--nogit <patch1> <patch2>
git send-email --suppress-cc all --dry-run --annotate --to
heiko@xxxxxxxxx --cc <..> <patch1> <patch2>
This SoC has no support in mainline linux kernel yet.
In all the following yaml documents for rk3568 we need headers with
defines for clocks and power domains, etc.
For example:
#include <dt-bindings/clock/rk3568-cru.h>
#include <dt-bindings/power/rk3568-power.h>
Could Rockchip submit first clocks and power drivers entries and a basic
rk3568.dtsi + evb dts?
Include a patch to this serie with 3 pcie nodes added to rk3568.dtsi.
A dtbs_check only works with a complete dtsi and evb dts.
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
On 1/18/21 10:17 AM, Simon Xue wrote:
Signed-off-by: Simon Xue <xxm@xxxxxxxxxxxxxx>
---
.../bindings/pci/rockchip-dw-pcie.yaml | 101 ++++++++++++++++++
1 file changed, 101 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
new file mode 100644
index 000000000000..fa664cfffb29
--- /dev/null
+++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
@@ -0,0 +1,101 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: DesignWare based PCIe RC controller on Rockchip SoCs
+
+maintainers:
+ - Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
+ - Simon Xue <xxm@xxxxxxxxxxxxxx>
maintainers:
- Heiko Stuebner <heiko@xxxxxxxxx>
Add only people with maintainer rights.
I'd disagree on this ;-)
All roads leads to Heiko... ;)
It takes long term commitment.
Year in, year out.
Keeping yourself up to date with the latest pcei development.
Communicate in English.
Be able to submit patches without errors... ;)
Review other peoples patches.
Respond in short time.
Bug fixing.
Crikey, it's only a DT binding... :/
If that's what you really want, then you must include a patch to this
serie for MAINTAINERS.
I think if Bjorn and Lorenzo want a specifically named sub-maintainer
for the driver itself, we can let them say so rather than presume.
Robin.
Check patch with:
./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS
--order
Otherwise it's safe to include that person mentioned above.
The maintainer for individual drivers should be the persons who are
actually know the hardware. We have individual Rockchip developers
taking care of other drivers as well already.
And normally scripts/get_maintainer.pl should already include me
due to the wildcard for things having "rockchip" in the name.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
