On Thu, Jan 14, 2021 at 4:52 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>
> On Thu, Jan 14, 2021 at 04:29:28PM +0800, Hongtao Wu wrote:
> > From: Hongtao Wu <billows.wu@xxxxxxxxxx>
> >
> > This series adds PCIe controller driver for Unisoc SoCs.
> > This controller is based on DesignWare PCIe IP.
> >
> > Signed-off-by: Hongtao Wu <billows.wu@xxxxxxxxxx>
> > ---
> > drivers/pci/controller/dwc/Kconfig | 12 ++
> > drivers/pci/controller/dwc/Makefile | 1 +
> > drivers/pci/controller/dwc/pcie-sprd.c | 293 +++++++++++++++++++++++++++++++++
> > 3 files changed, 306 insertions(+)
> > create mode 100644 drivers/pci/controller/dwc/pcie-sprd.c
>
> <...>
>
> > +static struct platform_driver sprd_pcie_driver = {
> > + .probe = sprd_pcie_probe,
> > + .remove = __exit_p(sprd_pcie_remove),
> ^^^^^^ why is that?
>
> > + .driver = {
> > + .name = "sprd-pcie",
> > + .of_match_table = sprd_pcie_of_match,
> > + },
> > +};
> > +
> > +module_platform_driver(sprd_pcie_driver);
> > +
> > +MODULE_DESCRIPTION("Unisoc PCIe host controller driver");
> > +MODULE_LICENSE("GPL v2");
>
> I think that it needs to be "GPL" and not "GPL v2".
>
> Thanks
Thanks for the review.
I'll fix it in the next version.
>
> > --
> > 2.7.4
> >
