On 06.01.2021 18:37, Bjorn Helgaas wrote: > On Wed, Jan 06, 2021 at 12:05:41PM +0100, Heiner Kallweit wrote: >> Use new PCI core function pci_quirk_broken_parity(), in addition to >> setting broken_parity_status is disables parity checking. > > That sentence has a typo or something so it doesn't read quite right. > Maybe: > > Use new PCI core function pci_quirk_broken_parity() to disable > parity checking. > OK, let me adjust this in a v3. > "broken_parity_status" is basically internal to the PCI core and > doesn't really seem relevant here. The only uses are the sysfs > store/show functions and edac. > >> This allows us to remove a quirk in r8169 driver. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> >> --- >> v2: >> - remove additional changes from this patch >> --- >> arch/arm/mach-iop32x/n2100.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-iop32x/n2100.c b/arch/arm/mach-iop32x/n2100.c >> index 78b9a5ee4..9f2aae3cd 100644 >> --- a/arch/arm/mach-iop32x/n2100.c >> +++ b/arch/arm/mach-iop32x/n2100.c >> @@ -125,7 +125,7 @@ static void n2100_fixup_r8169(struct pci_dev *dev) >> if (dev->bus->number == 0 && >> (dev->devfn == PCI_DEVFN(1, 0) || >> dev->devfn == PCI_DEVFN(2, 0))) >> - dev->broken_parity_status = 1; >> + pci_quirk_broken_parity(dev); >> } >> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_REALTEK, PCI_ANY_ID, n2100_fixup_r8169); >> >> -- >> 2.30.0 >> >>
