Re: [PATCH v8 4/9] of/iommu: Support dma-can-stall property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2020/12/14 下午8:51, Jean-Philippe Brucker wrote:
On Thu, Nov 26, 2020 at 06:09:26PM +0000, Robin Murphy wrote:
On 2020-11-12 12:55, Jean-Philippe Brucker wrote:
Copy the dma-can-stall property into the fwspec structure.
Can't we just handle this as a regular device property? It's not part of the
actual IOMMU specifier, it doesn't need to be translated in any way, and
AFAICS it's used a grand total of once, in a slow path. Simply treating it
as the per-device property that it is should require zero additional code
for DT, and a simple device_add_properties() call for IORT.

TBH that appears to be true of pasid-num-bits as well.
Right I think that's better, thanks for the pointer. I'll take care of
pasid-num-bits too. The Huawei quirk (fake PCIe supporting stall) is a
little worse this way, but it should work.

Thanks Jean, I tested the following diff, it works with Huawei quirk.

Thanks



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux