On 12/10/2020 12:46 AM, Rafał Miłecki wrote: >> This looks good to me now, just one nit, you probably do not support >> suspend/resume on the 4908, likely never will, but you should probably >> pulse the PERST# during PCIe resume, too. With that fixed: >> >> Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > > Driver already does that. > > Suspend forward trace: > brcm_pcie_suspend() > brcm_pcie_turn_off() > pcie->perst_set(pcie, 1) > > Resume forward trace: > brcm_pcie_resume() > brcm_pcie_setup() > pcie->perst_set(pcie, 0) > > Correct me if I'm wrong please. Nope, it's all good, my memory was incorrectly serving me, since perst_set() has been moved to a callback you have it called indeed. Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx> Thanks! -- Florian
