>> Some products are defining a range of DeviceIDs rather than one or two
>specific IDs, so these blocks are for catching any DeviceID in the
>range. I'm certainly open to suggestion for a better way to handle
>these, and I agree that the current way is awkward.
>
>I understand the need to have separate blocks for separate IDs and for
>ID ranges. But all the ranges could be covered by the same block:
>
> if ((device >= PCI_DEVICE_ID_INTEL_5_3400_SERIES_LPC_MIN &&
> device <= PCI_DEVICE_ID_INTEL_5_3400_SERIES_LPC_MAX)
> || (device >= PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MIN &&
> device <= PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MAX)) {
> r->name = "PIIX/ICH";
> r->get = pirq_piix_get;
> r->set = pirq_piix_set;
> return 1;
> }
Not sure why I didn't do it this way. Thanks for the help!
-Seth
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
