On Thu, Nov 26, 2020 at 12:59:27PM +0100, Geert Uytterhoeven wrote: > The R-Car PCIe controller does not use interrupts when configured > for endpoint mode, hence the bindings do not document the interrupt > property. However, all DTS files provide interrupts properties, and > thus fail to validate. > > Fix this by documenting the interrupts property. > > Fixes: 5be478f9c24fbdf8 ("dt-bindings: Another round of adding missing 'additionalProperties'") I don't think this fixes is appropriate. The commit itself wasn't broken, this binding is. > Fixes: 4c0f80920923f103 ("dt-bindings: PCI: rcar: Add bindings for R-Car PCIe endpoint controller") > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > --- > Alternatively, the interrupts properties should be removed from the > corresponding device nodes in the DTS files. Obviously they should be > retained in the device nodes representing PCIe controllers configured in > host mode, which describe the same hardware... No, I think this patch is the right change. EP and host bindings should be similiar. Fix your Sob and resend please. Rob