On Mon, Dec 07, 2020 at 02:52:58PM +0000, Christoph Hellwig wrote: > Can we take a step back? I think in general drivers should not bother > with pci_find_capability. Both mtip32xx and skd want to find out if > the devices are PCIe devices, skd then just prints the link speed for > which we have much better helpers, mtip32xx than messes with DEVCTL > which seems actively dangerous to me. Yes, that's a much better idea. Plus it would be a much more interesting mentorship project.