On Fri, Dec 4, 2020 at 10:58 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > From: Arnd Bergmann <arnd@xxxxxxxx> > > While the exynos driver does not always need MSI, the generic > deisgnware host code it uses fails to build without it: > > WARNING: unmet direct dependencies detected for PCIE_DW_HOST > Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n] > Selected by [y]: > - PCI_EXYNOS [=y] && PCI [=y] && (ARCH_EXYNOS [=n] || COMPILE_TEST [=y]) > drivers/pci/controller/dwc/pcie-designware-host.c:247:19: error: implicit declaration of function 'pci_msi_create_irq_domain' [-Werror,-Wimplicit-function-declaration] > pp->msi_domain = pci_msi_create_irq_domain(fwnode, > ^ > > Add back the dependency that all other designware controllers have. > > Fixes: f0a6743028f9 ("PCI: dwc: exynos: Rework the driver to support Exynos5433 variant") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > drivers/pci/controller/dwc/Kconfig | 1 + > 1 file changed, 1 insertion(+) Seems like we should rework this to avoid select on options with depends, but that's a separate change. > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index 020101b58155..e403bb2eeb4c 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP > config PCI_EXYNOS > tristate "Samsung Exynos PCIe controller" > depends on ARCH_EXYNOS || COMPILE_TEST > + depends on PCI && PCI_MSI_IRQ_DOMAIN PCI isn't needed here. > select PCIE_DW_HOST > help > Enables support for the PCIe controller in the Samsung Exynos SoCs > -- > 2.27.0 >