Bjorn, On 12/6/20 17:26, Bjorn Helgaas wrote: > There's a patch pending via the PCI tree to change the return type to > u8. We can do one of: I did not know about the pending patch, if that is going to change the return type then this patch makes sense. > > - Ignore this. It only changes something on the stack, so no real > space saving and there's no problem assigning the u8 return value > to the "int". > - The maintainer could ack it and I could merge it via the PCI tree > so it happens in the correct order (after the interface change). If we want it in 5.11 then I think PCI tree is a right way go about it. > - The PCI core interface change will be merged for v5.11, so we > could hold this until v5.12. > I don't really have a preference. The only place there would really > be a benefit would be if we store the return value in a struct, where > we could potentially save three bytes. Totally agree. > Bjorn Whoever is going to apply please add :- Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>
