On Fri, Dec 04, 2020 at 05:17:58PM +0000, Kelley, Sean V wrote: > On Dec 3, 2020, at 4:01 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > OK, so if we want a comment here, I assume it would be along the lines > > of: > > > > If "bridge" has no subordinate bus, it's an RCEC or an RCiEP. In > > either of those cases, we want to call the callback on "bridge" > > itself. > > Correct. OK, good. I think the function comment now captures this. > > So IIUC, the code would be: > > > > if (bridge->subordinate) > > pci_walk_bus(bridge->subordinate, cb, userdata); > > else > > cb(bridge, userdata); /* RCEC or RCiEP */ > > > > Right? > > Right, as before. Updated to match this. > > I pushed a pci/err branch > > (https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=pci/err) > > with some tweaks in these areas. Diff from your v12 posting appended > > below. I split the RCEC/RCiEP error recovery pieces up a little bit > > differently than in your posting. Let me know if you see anything > > that should be changed. I dropped one of Jonathan's > > reviewed/tested-by but probably should have dropped others to avoid > > putting words in his mouth. > > Thanks very much for doing this update. It looks good to me. I just updated this for the "rc used before initialization" error. Current head f74d7cf9f2bc ("PCI/AER: Add RCEC AER error injection support").
