On Fri, Nov 20, 2020 at 2:30 AM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: > > On Thu, 19 Nov 2020 at 00:42, Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > > > Thanks for continuing to drive this series Sami. For the series, > > > > Tested-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > > I did virtualized boot tests with the series applied to aarch64 > > defconfig without CONFIG_LTO, with CONFIG_LTO_CLANG, and a third time > > with CONFIG_THINLTO. If you make changes to the series in follow ups, > > please drop my tested by tag from the modified patches and I'll help > > re-test. Some minor feedback on the Kconfig change, but I'll post it > > off of that patch. > > > > When you say 'virtualized" do you mean QEMU on x86? Or actual > virtualization on an AArch64 KVM host? aarch64 guest on x86_64 host. If you have additional configurations that are important to you, additional testing help would be appreciated. > > The distinction is important here, given the potential impact of LTO > on things that QEMU simply does not model when it runs in TCG mode on > a foreign host architecture. -- Thanks, ~Nick Desaulniers