On Tue, Sep 22, 2020 at 11:30:30AM -0600, Rob Herring wrote: > On Mon, Sep 21, 2020 at 1:50 AM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: > > > > When establish link timeouts, probe fails but the error is unrelated since > > the PCIe controller has been probed succesfully. > > > > Align with most of the other dw-pcie drivers and ignore return of > > dw_pcie_wait_for_link() in the host_init callback. > > I think all, not most DWC drivers should be aligned. Plus the code > here is pretty much the same, so I'm working on moving all this to the > common DWC code. Drivers that need to bring up the link will need to > implement .start_link() (currently only used for EP mode). Most of the > time that is just setting the LTSSM bit which Synopsys thought letting > every vendor do their own register for was a good idea. Sigh. Should I drop this patch then ? Thanks, Lorenzo