Re: [PATCH] PCI: dwc: fix error return code in dw_pcie_host_init()

["wanghai (M)" <wanghai38@xxxxxxxxxx>]

在 2020/11/17 9:49, Jisheng Zhang 写道:
> On Mon, 16 Nov 2020 21:50:23 +0800 Wang Hai wrote:
>
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> good catch.
>
> > Fixes: 07940c369a6b ("PCI: dwc: Fix MSI page leakage in suspend/resume")
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Wang Hai <wanghai38@xxxxxxxxxx>
> >
> >                          if (dma_mapping_error(pci->dev, pp->msi_data)) {
> >                                  dev_err(pci->dev, "Failed to map MSI data\n");
> >                                  pp->msi_data = 0;
> > +                               ret = -ENOMEM;
> what about use the return value of dma_maping_error()? I.E
>
> ret = dma_mapping_error()
> if (ret) {
> ....
> }

Thanks for your review,  I just sent v2

"[PATCH v2] PCI: dwc: fix error return code in dw_pcie_host_init()"

> .