Hi Stuart, I love your patch! Perhaps something to improve: [auto build test WARNING on pci/next] [also build test WARNING on linus/master v5.10-rc3 next-20201109] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Stuart-Hayes/Expose-PCIe-SSD-Status-LED-Management-DSM-in-sysfs/20201109-100709 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: i386-randconfig-r015-20201109 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/71fa2ed2b9ac8be92eb60fb757e0333dd6788d2f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Stuart-Hayes/Expose-PCIe-SSD-Status-LED-Management-DSM-in-sysfs/20201109-100709 git checkout 71fa2ed2b9ac8be92eb60fb757e0333dd6788d2f # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/pci/pci-ssdleds.c:184:6: warning: no previous prototype for 'pci_create_ssdleds_files' [-Wmissing-prototypes] 184 | void pci_create_ssdleds_files(struct pci_dev *pdev) | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/pci/pci-ssdleds.c: In function 'pci_create_ssdleds_files': >> drivers/pci/pci-ssdleds.c:186:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 186 | int ret; | ^~~ drivers/pci/pci-ssdleds.c: At top level: >> drivers/pci/pci-ssdleds.c:191:6: warning: no previous prototype for 'pci_remove_ssdleds_files' [-Wmissing-prototypes] 191 | void pci_remove_ssdleds_files(struct pci_dev *pdev) | ^~~~~~~~~~~~~~~~~~~~~~~~ vim +/pci_create_ssdleds_files +184 drivers/pci/pci-ssdleds.c 183 > 184 void pci_create_ssdleds_files(struct pci_dev *pdev) 185 { > 186 int ret; 187 188 ret = sysfs_create_group(&pdev->dev.kobj, &ssdleds_attr_group); 189 } 190 > 191 void pci_remove_ssdleds_files(struct pci_dev *pdev) --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
