On Thu, Nov 05, 2020 at 10:34:15AM -0400, Jason Gunthorpe wrote:
> On Thu, Nov 05, 2020 at 08:42:02AM +0100, Christoph Hellwig wrote:
> > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> > index 5f8fd7976034e0..661e4a22b3cb81 100644
> > +++ b/include/rdma/ib_verbs.h
> > @@ -3950,6 +3950,8 @@ static inline int ib_req_ncomp_notif(struct ib_cq *cq, int wc_cnt)
> > */
> > static inline int ib_dma_mapping_error(struct ib_device *dev, u64 dma_addr)
> > {
> > + if (!dev->dma_device)
> > + return 0;
>
> How about:
>
> static inline bool ib_uses_virt_dma(struct ib_device *dev)
> {
> return IS_ENABLED(CONFIG_INFINIBAND_VIRT_DMA) && !dev->dma_device;
> }
>
> Which is a a little more guidance that driver authors need to set this
> config symbol.
Sure, I'll do that.
