On Wed, Nov 4, 2020 at 6:13 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Wed, 2020-11-04 at 16:48 +0100, Maximilian Luz wrote:
> > On 11/4/20 6:13 AM, Joe Perches wrote:
> >
> > [...]
> >
> > > > Yes. I scanned drivers/acpi for trailing whitespaces after I noticed a
> > > > couple of them. I did not explicitly scan for other stuff like spaces
> > > > where there should be tabs, mostly because I haven't found a quick and
> > > > reliable solution for that. I only noticed an inconsistent indentation
> > > > when committing, so I fixed that too.
> > >
> > > You could try:
> > >
> > > $ git ls-files -- 'drivers/acpi/*.[ch]' | \
> > > xargs ./scripts/checkpatch.pl -f --fix-inplace --types=CODE_INDENT
> >
> > Thanks, that indeed looks like a decent solution.
> >
> > > Right now that produces:
> > > ---
> >
> > [...]
> >
> > > diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> []
> > > @@ -89,7 +89,7 @@ struct acpi_ac {
> > > #define to_acpi_ac(x) power_supply_get_drvdata(x)
> > >
> > >
> > > /* --------------------------------------------------------------------------
> > > - AC Adapter Management
> > > + AC Adapter Management
> > > -------------------------------------------------------------------------- */
> >
> > I'm not too sure about the comments, but I can find the time to look
> > over the output and adjust that if that's something you'd want me to do.
>
> Up to you. I hardly looked at the output.
>
> I'd generally prefer to use a single line comment like
>
> /* AC Adapter Management */
>
> but I don't know how often that dashed block is used in ACPI.
>
> grep seems to show the texts are not correctly centered so it seems like
> it was done by hand and not that some automation tool was used to create
> those blocks.
>
> Maybe a separate patch could be done to change those if desired.
If anyone has a problem with them.
> But not by me.
>
> As far as I know, acpi was once autogenerated from a common source tree
> and whitespace changes were once frowned on, but maybe that's changed or
> or perhaps that's only for files in drivers/acpi/acpica/.
The latter.
