On Sat, Oct 31, 2020 at 04:53:59PM -0700, Raj, Ashok wrote: > If we are doing this just to improve review effectiveness, Now we would need > some parent driver, and these sub-drivers registering seemed like a bit of > over-engineering when these sub-drivers actually are an extension of the > base driver and offer nothing more than extending sub-device partitions > of IDXD for guest drivers. These look and feel like IDXD, not another device > interface. In that sense if we move PF/VF mailboxes as > separate drivers i thought it feels a bit odd. You need this split anyhow, putting VFIO calls into the main idxd module is not OK. Plugging in a PCI device should not auto-load VFIO modules. Jason