Hi Dave, I love your patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on v5.10-rc1 next-20201030] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dave-Jiang/PCI-add-helper-function-to-find-DVSEC/20201031-220304 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: x86_64-rhel (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/5c1551e498323db6a917599f6f79f37080c22825 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dave-Jiang/PCI-add-helper-function-to-find-DVSEC/20201031-220304 git checkout 5c1551e498323db6a917599f6f79f37080c22825 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/pci/pci.c: In function 'pci_find_dvsec': >> drivers/pci/pci.c:605:37: error: 'PCI_EXT_CAP_ID_DVSEC' undeclared (first use in this function); did you mean 'PCI_EXT_CAP_ID_DPC'? 605 | pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DVSEC); | ^~~~~~~~~~~~~~~~~~~~ | PCI_EXT_CAP_ID_DPC drivers/pci/pci.c:605:37: note: each undeclared identifier is reported only once for each function it appears in >> drivers/pci/pci.c:610:35: error: 'PCI_DVSEC_HEADER1' undeclared (first use in this function); did you mean 'PCI_VSEC_HDR'? 610 | pci_read_config_word(dev, pos + PCI_DVSEC_HEADER1, &dev_vendor); | ^~~~~~~~~~~~~~~~~ | PCI_VSEC_HDR >> drivers/pci/pci.c:611:35: error: 'PCI_DVSEC_HEADER2' undeclared (first use in this function); did you mean 'PCI_VSEC_HDR'? 611 | pci_read_config_word(dev, pos + PCI_DVSEC_HEADER2, &dev_id); | ^~~~~~~~~~~~~~~~~ | PCI_VSEC_HDR vim +605 drivers/pci/pci.c 591 592 /** 593 * pci_find_dvsec - return position of DVSEC with provided vendor and DVSEC ID 594 * @dev: the PCI device 595 * @vendor: vendor for the DVSEC 596 * @id: the DVSEC capibility ID 597 * 598 * Return the offset of DVSEC on success or -ENOTSUPP if not found 599 */ 600 int pci_find_dvsec(struct pci_dev *dev, u16 vendor, u16 id) 601 { 602 u16 dev_vendor, dev_id; 603 int pos; 604 > 605 pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DVSEC); 606 if (!pos) 607 return -ENOTSUPP; 608 609 while (pos) { > 610 pci_read_config_word(dev, pos + PCI_DVSEC_HEADER1, &dev_vendor); > 611 pci_read_config_word(dev, pos + PCI_DVSEC_HEADER2, &dev_id); 612 if (dev_vendor == vendor && dev_id == id) 613 return pos; 614 615 pos = pci_find_next_ext_capability(dev, pos, PCI_EXT_CAP_ID_DVSEC); 616 } 617 618 return -ENOTSUPP; 619 } 620 EXPORT_SYMBOL_GPL(pci_find_dvsec); 621 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
