On Thu, Dec 02, 2010 at 11:51:39PM +0100, Rafael J. Wysocki wrote:
> On Thursday, December 02, 2010, Matthew Garrett wrote:
> > On Thu, Dec 02, 2010 at 11:24:31PM +0100, Rafael J. Wysocki wrote:
> > > > + if (!aspm_force) {
> > > > aspm_disabled = 1;
> > > > + if (clear)
> > > > + aspm_clear_state = clear;
> > >
> > > Well, is the if(clear) really necessary?
> >
> > If the FADT disables ASPM, and then we fail to get the control bits,
> > we'd call this twice and turn off aspm_clear_state.
>
> Ah, thanks. So if you used a separate function for handling the "BIOS tells
> us there's no ASPM" case, that wouldn't be necessary? ;-)
Yeah. I'll rework and resend - I've also figured out that we need to
clear the common PM bit.
--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
