On Tue, Oct 20, 2020 at 09:02:19AM +0100, Christoph Hellwig wrote: > On Sun, Oct 18, 2020 at 11:14:53PM -0700, Randy Dunlap wrote: > > Fix a build error in drivers/mfd/ioc.o by exporting > > pci_find_host_bridge(). > > > > ERROR: modpost: "pci_find_host_bridge" [drivers/mfd/ioc3.ko] undefined! > > I think the mfd code should be fixed to not depend on such an internal > symbol instead. are you talking about the EXPORT_SYMBOL or the usage of pci_find_host_bridge() outside of drivers/pci ? If the latter the function is used in arm/arm64 code and pci controller code... so I doesn't look like a pure internal symbol to me. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]