On Wed, Oct 14, 2020 at 11:43 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Tue, Oct 13, 2020 at 08:17:39AM -0700, Kuppuswamy, Sathyanarayanan wrote: > > > > > > On 10/13/20 4:56 AM, Christoph Hellwig wrote: > > > You might want to split out pcie_do_fatal_recovery and get rid of the > > > state argument: > > This is how it was before Keith merged fatal and non-fatal error recovery > > paths. When the comparison is between additional-parameter vs new-interface > > , I choose the former. But I can merge your change in next version. > > But now you split the implementation. Keith merged made complete sense > when the code was mostly identical. But now that the code is separate > again it doesn't make sense to hide it under a common interface that > uses a flags value to call different functions. Agreed. Already included this change in v6.
