On 10/12/2020 1:13 AM, Kuppuswamy, Sathyanarayanan wrote: > Hi Sinan, > > On 9/28/20 11:32 AM, Kuppuswamy, Sathyanarayanan wrote: >> >> >> On 9/28/20 11:25 AM, Sinan Kaya wrote: >>> On 9/28/2020 2:02 PM, Sinan Kaya wrote: >>>> Since there is no state restoration for FATAL errors, I am wondering >>>> whether >>>> calls to ->error_detected(), ->mmio_enabled() and ->slot_reset() are >>>> required? >>> >>> I also would like to ask someone closer to the spec language double >>> check this. >>> >>> When we recover the link at the end of the DPC handler, what is the >>> expected state of the endpoint? >>> >>> Is it a some kind of a reset like secondary bus reset? (I assumed this >>> one) >> I think it will be in reset state. >>> >>> Undefined? >>> >>> or just plain link recovery with everything else as intact as it used >>> to be? >>> >> > > Please check the following version. It should fix most of the reset issues > properly. > > https://lore.kernel.org/linux-pci/5c5bca0bdb958e456176fe6ede10ba8f838fbafc.1602263264.git.sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx/T/#t > > Thanks, good stuff.