Hi Linus, On Wed, Oct 7, 2020 at 11:14 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Sun, Oct 4, 2020 at 8:00 PM Martin Blumenstingl > <martin.blumenstingl@xxxxxxxxxxxxxx> wrote: > > > Add the vendor ID for Etron Technology, Inc. as well as the device IDs > > for the two USB xHCI controllers EJ168 and EJ188. > > > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > > (...) > > > #define PCI_VENDOR_ID_REDHAT 0x1b36 > > > > +#define PCI_VENDOR_ID_ETRON 0x1b6f > > +#define PCI_DEVICE_ID_ETRON_EJ168 0x7023 > > +#define PCI_DEVICE_ID_ETRON_EJ188 0x7052 > > If you're defining that here, I think it should also be > removed in > drivers/usb/host/xhci-pci.c > by including this file instead? you are absolutely right - I missed that part I will change this in v2 - thanks for pointing it out! Best regards, Martin