On Thu, Oct 01, 2020 at 07:48:23AM -0500, Rob Herring wrote:
> On Wed, Sep 30, 2020 at 5:37 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> >
> > These warnings are sort of annoying. I guess most of the other
> > drivers avoid this by depending on OF as well as COMPILE_TEST.
>
> Using the of_match_ptr() macro should prevent this.
Both drivers *do* use of_match_ptr(), but the of_device_id table is
unused when of_match_ptr() throws away the pointer.
I guess we could add __maybe_unused to squelch the warning. Ugly, but
I do think COMPILE_TEST has some value.
> > $ grep -E "CONFIG_(OF|PCIE_(SPEAR13XX|ARMADA_8K))" .config
> > CONFIG_PCIE_SPEAR13XX=y
> > CONFIG_PCIE_ARMADA_8K=y
> > # CONFIG_OF is not set
> >
> > $ make W=1 drivers/pci/
> > ...
> > CC drivers/pci/controller/dwc/pcie-spear13xx.o
> > drivers/pci/controller/dwc/pcie-spear13xx.c:270:34: warning: ‘spear13xx_pcie_of_match’ defined but not used [-Wunused-const-variable=]
> > 270 | static const struct of_device_id spear13xx_pcie_of_match[] = {
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> > ...
> > CC drivers/pci/controller/dwc/pcie-armada8k.o
> > drivers/pci/controller/dwc/pcie-armada8k.c:344:34: warning: ‘armada8k_pcie_of_match’ defined but not used [-Wunused-const-variable=]
> > 344 | static const struct of_device_id armada8k_pcie_of_match[] = {
> > | ^~~~~~~~~~~~~~~~~~~~~~
> >
