On Tue, 26 Oct 2010 15:02:17 -0700 "Tom Lyon" <pugs@xxxxxxxxx> wrote: > In the next version of my VFIO driver, I have cleaned up all my > pci config access code to use the defines here, but have needed to add a > bunch more. What is the feeling about taking such a large patch? > > Basically, I have completed the PCI capability and extended capabilities > lists and made them current with the "PCI Code and ID Assignment Specification > Revision 1.0" of September 9, 2010. For all fixed size capabilities I added > a _SIZEOF definition; for the variable size ones I added enough to figure out > the size. These are all standard regs & locations, so I have no problem adding them to the header. Did you use SIZEOF instead of SIZE because there are collisions if you use the latter? -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html