On Mon, 04 Oct 2010 12:49:24 -0600
Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote:
>
> The end of an MMCONFIG region depends on the ending bus number, not on the
> number of buses the region covers. We previously computed the wrong ending
> address whenever the starting bus number was non-zero, e.g.,:
>
> MMCONFIG for [bus 00-1f] at [mem 0xe0000000-0xe1ffffff] (base 0xe0000000)
> MMCONFIG for [bus 20-3f] at [mem 0xe2000000-0xe1ffffff] (base 0xe0000000)
>
> The correct regions are:
>
> MMCONFIG for [bus 00-1f] at [mem 0xe0000000-0xe1ffffff] (base 0xe0000000)
> MMCONFIG for [bus 20-3f] at [mem 0xe2000000-0xe3ffffff] (base 0xe0000000)
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> ---
>
> arch/x86/pci/mmconfig-shared.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
>
> diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
> index a918553..e282886 100644
> --- a/arch/x86/pci/mmconfig-shared.c
> +++ b/arch/x86/pci/mmconfig-shared.c
> @@ -65,7 +65,6 @@ static __init struct pci_mmcfg_region *pci_mmconfig_add(int segment, int start,
> int end, u64 addr)
> {
> struct pci_mmcfg_region *new;
> - int num_buses;
> struct resource *res;
>
> if (addr == 0)
> @@ -82,10 +81,9 @@ static __init struct pci_mmcfg_region *pci_mmconfig_add(int segment, int start,
>
> list_add_sorted(new);
>
> - num_buses = end - start + 1;
> res = &new->res;
> res->start = addr + PCI_MMCFG_BUS_OFFSET(start);
> - res->end = addr + PCI_MMCFG_BUS_OFFSET(num_buses) - 1;
> + res->end = addr + PCI_MMCFG_BUS_OFFSET(end + 1) - 1;
> res->flags = IORESOURCE_MEM | IORESOURCE_BUSY;
> snprintf(new->name, PCI_MMCFG_RESOURCE_NAME_LEN,
> "PCI MMCONFIG %04x [bus %02x-%02x]", segment, start, end);
>
>
Nice fix, applied, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
