Re: [PATCH] x86/PCI: ignore "BARs" that overlap MMCONFIG regions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/15/2010 01:04 PM, Jesse Barnes wrote:
> 
> So we have a couple of bugs here?
>   - device reports incorrect range (according to Yinghai this is a
>     hardware bug)
>   - BIOS doesn't set the hidden bit to make this BAR invisible
> 
> So rather than applying the quirk which might hide future problems it
> seems we should fix the range reporting with a quirk and possibly set
> the hidden bit on chipsets that support it (though I'd be happier if I
> knew the failure to set it really was a BIOS bug; I guess we won't know
> unless we figure out how Windows behaves on these platforms).
> 

There are a couple of problems:

a) Linux doesn't handle it correctly when MMCONFIG is a BAR.
   This is legitimate and in fact explicitly stated as a valid
   configuration in the PCIe spec; the BAR, of course, has to be
   configured by BIOS using ports CF8/CFC.
b) The BAR is the wrong size (unless it is expected to configure two
   different domains, or something.)
c) Given (b), the BIOS should probably have hidden the BAR as a
   workaround.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux