On Mon, 20 Sep 2010 18:50:00 +0200 "Rafael J. Wysocki" <rjw@xxxxxxx> wrote: > On Monday, September 20, 2010, Chen Gong wrote: > > ä 9/20/2010 6:02 AM, Rafael J. Wysocki åé: > > > From: Rafael J. Wysocki<rjw@xxxxxxx> > > > > > > There is a design issue related to PCIe AER and _OSC that the BIOS > > > may be asked to grant control of the AER service even if some > > > Hardware Error Source Table (HEST) entries contain information > > > meaning that the BIOS really should control it. Namely, > > > pcie_port_acpi_setup() calls pcie_aer_get_firmware_first() that > > > determines whether or not the AER service should be controlled by > > > the BIOS on the basis of the HEST information for the given PCIe > > > port. The BIOS is asked to grant control of the AER service for > > > a PCIe Root Complex if pcie_aer_get_firmware_first() returns 'false' > > > for at least one root port in that complex, even if all of the other > > > root ports' HEST entries have the FIRMWARE_FIRST flag set (and none > > > of them has the GLOBAL flag set). However, if the AER service is > > > controlled by the kernel, that may interfere with the BIOS' handling > > > of the error sources having the FIRMWARE_FIRST flag. Moreover, > > > there may be PCIe endpoints that have the FIRMWARE_FIRST flag set in > > > HEST and are attached to the root ports in question, in which case it > > > also may be unsafe to ask the BIOS for control of the AER service. > > > > > > For this reason, introduce a function checking if there's at least > > > one PCIe-related HEST entry with the FIRMWARE_FIRST flag set and > > > disable the native AER service altogether if this function returns > > > 'true'. Applied the second patch to my linux-next branch, thanks. -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
