My main goal with this patch is to enable an IOHub/companion chip with 16 drivers (in the pipe to be submitted). The PCI device id's are managed elsewhere, but I thought that it would make sense to enable the Vendor id in the pci_id.h file. As Matthew are saying ST micro makes a lot of chips and that by itself would make justify to put this in Anders Wallin, Senior Member of Technical Staff, Wind River > -----Original Message----- > From: Matthew Wilcox [mailto:matthew@xxxxxx] > Sent: Thursday, September 23, 2010 9:36 PM > To: Greg KH > Cc: Wallin, Anders; linux-pci@xxxxxxxxxxxxxxx; qi.wang@xxxxxxxxx > Subject: Re: [PATCH 1/1] adding PCI vendor id for STmicroelectronics > > On Thu, Sep 23, 2010 at 12:15:07PM -0700, Greg KH wrote: > > On Thu, Sep 23, 2010 at 07:39:04PM +0200, > Anders.Wallin@xxxxxxxxxxxxx wrote: > > > +#define PCI_VENDOR_ID_STMICRO 0x104A > > > > Why is this needed? > > > > Did you read the comment at the top of this file? > > To be fair, ST Micro make a fair variety of chips. I can > imagine there being multiple drivers that want to use the ST > Micro vendor ID. I think the rule makes sense for device > IDs, but not for vendor IDs. > > -- > Matthew Wilcox Intel Open > Source Technology Centre > "Bill, look, we understand that you're interested in selling > us this operating system, but compare it to ours. We can't > possibly take such a retrograde step." > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
