On Wed, Aug 18, 2010 at 12:07:56PM -0700, Tom Lyon wrote: > On Tuesday, August 17, 2010 04:21:25 pm Greg KH wrote: > > On Tue, Aug 17, 2010 at 04:18:40PM -0700, Tom Lyon wrote: > > > Export symbols for pci_user_read_config_* and pci_user_write_config_* so > > > that they may be used in the vfio driver. > > > > > > Signed-off-by: Tom Lyon <pugs@xxxxxxxxx> > > > > > > --- > > > diff --git a/drivers/pci/access.c b/drivers/pci/access.c > > > index 531bc69..96ed449 100644 > > > --- a/drivers/pci/access.c > > > +++ b/drivers/pci/access.c > > > @@ -157,7 +157,8 @@ int pci_user_read_config_##size > \ > > > > > > raw_spin_unlock_irq(&pci_lock); \ > > > *val = (type)data; \ > > > return ret; \ > > > > > > -} > > > +} \ > > > +EXPORT_SYMBOL_GPL(pci_user_read_config_##size); > > > > We need the vfio driver in the tree first, don't you think? Otherwise > > it doesn't make sense to add these... > > There's a chicken and egg problem there, and I thought this approach might > keep the vfio patch smaller. Foolish me. Just do a 1/2 for this patch, and 2/2 for the vfio patch. Not a big deal, and you still keep your "smaller" patch :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html