Re: [PATCH] PCI: hotplug: pciehp: Fixed return value sign for pciehp_unconfigure_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 12 Jul 2010 11:12:25 -0500
Praveen Kalamegham <praveen@xxxxxxxxxx> wrote:

> pciehp_unconfigure_device() should return -EINVAL, not EINVAL.
> 
> Signed-off-by: Praveen Kalamegham <praveen@xxxxxxxxxx>
> ---
>  drivers/pci/hotplug/pciehp_pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/pciehp_pci.c b/drivers/pci/hotplug/pciehp_pci.c
> index 2fce726..a4031df 100644
> --- a/drivers/pci/hotplug/pciehp_pci.c
> +++ b/drivers/pci/hotplug/pciehp_pci.c
> @@ -137,7 +137,7 @@ int pciehp_unconfigure_device(struct slot *p_slot)
>  					 "Cannot remove display device %s\n",
>  					 pci_name(temp));
>  				pci_dev_put(temp);
> -				rc = EINVAL;
> +				rc = -EINVAL;
>  				break;
>  			}
>  		}

Applied to my linux-next branch, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux