On Thu, 17 Jun 2010 20:16:36 +0100 Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> wrote: > During suspend on an SMP system, {read,write}_msi_msg_desc() may be > called to mask and unmask interrupts on a device that is already in a > reduced power state. At this point memory-mapped registers including > MSI-X tables are not accessible, and config space may not be fully > functional either. > > While a device is in a reduced power state its interrupts are > effectively masked and its MSI(-X) state will be restored when it is > brought back to D0. Therefore these functions can simply read and > write msi_desc::msg for devices not in D0. > > Further, read_msi_msg_desc() should only ever be used to update a > previously written message, so it can always read msi_desc::msg > and never needs to touch the hardware. > > Signed-off-by: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> Applied to my linux-next branch, thanks. Matthew, let me know if you have an issue with this. Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html